<html>
<head><meta charset="utf-8"><title>Can I nominate issues if I&#x27;m not on T-lang? · t-lang · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/index.html">t-lang</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html">Can I nominate issues if I&#x27;m not on T-lang?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="227680009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680009">(Feb 24 2021 at 21:57)</a>:</h4>
<p>I really like <a href="https://github.com/rust-lang/rust/issues/82499">https://github.com/rust-lang/rust/issues/82499</a> and would love for it to be discussed in a T-lang meeting at some point. Can I nominate it myself?</p>



<a name="227680148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680148">(Feb 24 2021 at 21:58)</a>:</h4>
<p>Yes, as long as there's a very clear summary of what decision or evaluation is being requested from the team.</p>



<a name="227680235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680235">(Feb 24 2021 at 21:59)</a>:</h4>
<p>That said, I don't think most of those should have a lint against them, even an allow-by-default one...</p>



<a name="227680246"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680246" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680246">(Feb 24 2021 at 21:59)</a>:</h4>
<p>But it's something we could discuss.</p>



<a name="227680452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680452">(Feb 24 2021 at 22:00)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I'm.20not.20on.20T-lang.3F/near/227680148">said</a>:</p>
<blockquote>
<p>Yes, as long as there's a very clear summary of what decision or evaluation is being requested from the team.</p>
</blockquote>
<p>I think the decision is just "should there be a lint"</p>



<a name="227680551"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680551" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680551">(Feb 24 2021 at 22:00)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I'm.20not.20on.20T-lang.3F/near/227680235">said</a>:</p>
<blockquote>
<p>That said, I don't think most of those should have a lint against them, even an allow-by-default one...</p>
</blockquote>
<p>really? I'm surprised to hear that, these can all cause UB even with <code>forbid(unsafe_code)</code> on</p>



<a name="227680747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227680747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227680747">(Feb 24 2021 at 22:01)</a>:</h4>
<blockquote>
<p>these can all cause UB </p>
</blockquote>
<p>(well - apparently not all of them, as <span class="user-mention silent" data-user-id="210267">Nemo157</span> just commented, but assuming we whittle it down to the ones that can)</p>



<a name="227681561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227681561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227681561">(Feb 24 2021 at 22:04)</a>:</h4>
<p>To clarify: I don't think they should have a separate lint. It's not something we could ever enable by default, and it seems unlikely someone would go out of their way to enable it. It seems more likely someone would set <code>forbid(unsafe_code)</code> and think they were covered. I'm wondering if they should be forbidden by <code>forbid(unsafe_code)</code> instead. (I also wonder if that would lead to breakage.)</p>



<a name="227681937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227681937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227681937">(Feb 24 2021 at 22:06)</a>:</h4>
<p>We could, for instance, do that over an edition boundary to reduce the breakage. (Lints are allowed breakage, but this might be widespread.)</p>



<a name="227682027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227682027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227682027">(Feb 24 2021 at 22:06)</a>:</h4>
<p>I'd only want to do that for the ones that can <em>actually</em> do unsafe things, though.</p>



<a name="227682749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227682749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227682749">(Feb 24 2021 at 22:09)</a>:</h4>
<p>AFAICT, no_mangle and export_name are now checked by <code>unsafe_code</code>, right?</p>



<a name="227682762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227682762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227682762">(Feb 24 2021 at 22:09)</a>:</h4>
<p>I don't think they're a separate lint.</p>



<a name="227683347"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683347" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683347">(Feb 24 2021 at 22:13)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> <a href="https://github.com/rust-lang/rust/issues/82499#issuecomment-785418613">https://github.com/rust-lang/rust/issues/82499#issuecomment-785418613</a></p>



<a name="227683359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683359">(Feb 24 2021 at 22:13)</a>:</h4>
<p>Does that seem like a reasonable summary to you?</p>



<a name="227683510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683510">(Feb 24 2021 at 22:13)</a>:</h4>
<p>I think making <code>unsafe_code</code> be functionally <code>anything_that_can_cause_ub</code> makes good sense to me.  I don't see much need for separate lints.</p>



<a name="227683701"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683701" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683701">(Feb 24 2021 at 22:14)</a>:</h4>
<p>I suspect that <code>link_section</code> and <code>forbid(unsafe_code)</code>/<code>deny(unsafe_code)</code> probably don't appear together. A crater run should tell us.</p>



<a name="227683733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683733">(Feb 24 2021 at 22:14)</a>:</h4>
<p>So we can probably just add that check.</p>



<a name="227683844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683844">(Feb 24 2021 at 22:15)</a>:</h4>
<p>And FWIW, the breakage from adding <code>no_mangle</code> resulted in one of the two crates that broke responding with "thank you" <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="227683982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227683982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227683982">(Feb 24 2021 at 22:16)</a>:</h4>
<p>I think I have a philosophical disagreement that warnings should never be consider a breaking change (and so crater isn't necessary). Other than that your comment makes sense to me :)</p>



<a name="227684153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227684153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227684153">(Feb 24 2021 at 22:17)</a>:</h4>
<p>I think we're always <em>allowed</em>, and if something is unsound we'd go ahead. But I'd like the crater run to tell us what we're in for.</p>



<a name="227684333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227684333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227684333">(Feb 24 2021 at 22:18)</a>:</h4>
<p>If, for instance, it had turned out that many <em>hundreds</em> of crates used <code>no_mangle</code> and <code>deny(unsafe_code)</code> together, then I'd want to be more cautious and perhaps fix some of the most common crates first.</p>



<a name="227684366"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227684366" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227684366">(Feb 24 2021 at 22:18)</a>:</h4>
<p>It's not that we <em>can't</em>, it's that I'd prefer to make a well-informed decision.</p>



<a name="227684441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227684441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227684441">(Feb 24 2021 at 22:19)</a>:</h4>
<p>Also, crater runs sometimes show us things we hadn't thought of. "Oh, <em>that's</em> why you might want to do that; perhaps we should tweak the check."</p>



<a name="227684658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227684658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227684658">(Feb 24 2021 at 22:20)</a>:</h4>
<p>Fair enough, that makes sense to me. Not sure I see why we'd change it but that is the point of unknown unknowns after all.</p>



<a name="227694155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227694155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227694155">(Feb 24 2021 at 23:37)</a>:</h4>
<p>I did see the other day that crater has a "top N crates" mode.  Makes me ponder whether for fine-but-just-in-case it would make sense to just do a "top 10,000" run, or similar, rather than needing to wait for an all-291444 run.</p>



<a name="227741862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227741862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227741862">(Feb 25 2021 at 09:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I'm.20not.20on.20T-lang.3F/near/227683982">said</a>:</p>
<blockquote>
<p>I think I have a philosophical disagreement that warnings should never be consider a breaking change (and so crater isn't necessary). Other than that your comment makes sense to me :)</p>
</blockquote>
<p>this is why we have cap-lints, as well</p>



<a name="227741906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Can%20I%20nominate%20issues%20if%20I%27m%20not%20on%20T-lang%3F/near/227741906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Can.20I.20nominate.20issues.20if.20I&#x27;m.20not.20on.20T-lang.3F.html#227741906">(Feb 25 2021 at 09:48)</a>:</h4>
<p>though I still think crater-and-ping is polite</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>